haskell/haskell-ide-engine

HLint suggestions and CPP don't play well together

Open

#675 opened on Jul 10, 2018

View on GitHub
聽(2 comments)聽(0 reactions)聽(0 assignees)Haskell聽(2,358 stars)聽(205 forks)batch import
component: documentationgardening 馃尡good first issuehelp wanted

Description

When I apply an hlint-suggestion to a piece of code where CPP is used somewhere else in the file, the expanded CPP is weirdly expanded.

Contributor guide

Tech stack
None
Domain
toolingdeveloper experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
needs investigation
Prerequisites
Basic Haskell knowledgeFamiliarity with HLintUnderstanding of CPP preprocessing
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
20
Research direction
Investigate the interaction between HLint suggestions and CPP in the haskell ide engine. Examine the code that applies HLint suggestions (likely in Language.Haskell.HLint or similar) and how CPP is expanded before or after. Look at related issues or comments for more context.
HLint suggestions and CPP don't play well together 路 haskell/haskell-ide-engine#675 | Good First Issue