Improper encoding of reserved characters

Open
#83 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
haskell
Domain
networking

Research direction

The issue does not name a file or test; start by tracing how HTTP_PROXY values are parsed and reproduce a password containing percent-encoded reserved characters such as %40 and %21. Done should mean these characters are accepted and the request uses the intended host, with regression coverage for the proxy URL case.

Written by the indexing model from the issue text.

Description

This was originally reported as a Cabal bug, but I believe it belongs here:

The value of HTTP_PROXY has as format
http://user:pass@host:80/

In the password special characters can occur, like @ and !.
According to wiki (http://en.wikipedia.org/wiki/Percent-escape)
these characters must be percent-encoded, like %40 and %21.

Cabal doesn't accept percent-encoded characters.
And cabal errs on these characters (if password is a@b, Cabal doesn't look to the right site, but >probably to "b@host:80" (error message is not clear enough to be certain)

Dominant language
Haskell
Stars
186
Forks
59
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from haskell/HTTP

All issues in haskell/HTTP

Similar issues

More Haskell issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.