haskell-servant/servant

Make `Servant.Client.Ghcjs.runClientM` take in a `ClientEnv`

Open

#945 opened on Apr 14, 2018

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Haskell (422 forks)batch import
help wanted

Repository metrics

Stars
 (1,953 stars)
PR merge metrics
 (Avg merge 5h 49m) (2 merged PRs in 30d)

Description

This would bring it in line with Servant.Client.runClientM. ClientEnv also needs to be exported from Servant.Client.Ghcjs.

Currently it seems like it's impossible to use ClientEnv without importing from Internal modules, which isn't ideal.

Contributor guide

Research direction
Update the Ghcjs module to accept ClientEnv and export it, mirroring the main runClientM signature.
Tech stack
haskell
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
HaskellServant
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75