haskell-servant/servant

Make `Servant.Client.Ghcjs.runClientM` take in a `ClientEnv`

Open

#945 opened on Apr 14, 2018

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Haskell (1,953 stars) (422 forks)batch import
help wanted

Description

This would bring it in line with Servant.Client.runClientM. ClientEnv also needs to be exported from Servant.Client.Ghcjs.

Currently it seems like it's impossible to use ClientEnv without importing from Internal modules, which isn't ideal.

Contributor guide

Tech stack
None
Domain
backendapi
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
basic Haskellfamiliarity with Servant library
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Look at the current implementation of `Servant.Client.runClientM` to understand how it uses `ClientEnv`. Then modify `Servant.Client.Ghcjs.runClientM` to accept a `ClientEnv` parameter similarly. Ensure `ClientEnv` is exported from `Servant.Client.Ghcjs` module, possibly by importing from internal modules or re exporting. Check the existing issue comments for any additional context.