haskell-servant/servant

client streaming + http redirect result into runtime exception

Open

#1091 opened on Nov 28, 2018

View on GitHub
 (7 comments) (0 reactions) (0 assignees)Haskell (1,953 stars) (422 forks)batch import
enhancementhelp wanted

Description

If an http endpoint returns a redirect (for example http -> https upgrade), streaming client errors out:

HasClient @StreamBody
CallStack (from HasCallStack):
  error, called at src/Servant/Client/Core/Internal/HasClient.hs:550:44 in servant-client-core-0.15-KKVc3oxuLh47HhicA3CWtB:Servant.Client.Core.Internal.HasClient

https://github.com/haskell-servant/servant/blob/master/servant-client-core/src/Servant/Client/Core/Internal/HasClient.hs#L550

Contributor guide

Tech stack
None
Domain
backendapi
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Haskell programmingservant library familiarityHTTP streaming concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
20
Research direction
Investigate the handling of HTTP redirects in the streaming client code at servant client core/src/Servant/Client/Core/Internal/HasClient.hs line 550. Determine if the current error is a missing implementation or a bug. Look at related issues or PRs for redirect handling. Consider implementing redirect following for streaming requests or providing a clear error message.