haskell-servant/servant

client streaming + http redirect result into runtime exception

Open

#1,091 opened on Nov 28, 2018

View on GitHub
 (7 comments) (0 reactions) (0 assignees)Haskell (422 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (1,953 stars)
PR merge metrics
 (Avg merge 5h 49m) (2 merged PRs in 30d)

Description

If an http endpoint returns a redirect (for example http -> https upgrade), streaming client errors out:

HasClient @StreamBody
CallStack (from HasCallStack):
  error, called at src/Servant/Client/Core/Internal/HasClient.hs:550:44 in servant-client-core-0.15-KKVc3oxuLh47HhicA3CWtB:Servant.Client.Core.Internal.HasClient

https://github.com/haskell-servant/servant/blob/master/servant-client-core/src/Servant/Client/Core/Internal/HasClient.hs#L550

Contributor guide

Research direction
Inspect the error at line 550 of HasClient.hs and understand how the streaming client handles HTTP redirects. Consider implementing proper redirect handling for streaming endpoints.
Tech stack
None
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
HaskellServant
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40