haskell-nix/hnix

Please, check & find superflous `coerce`

Open

#986 opened on Aug 14, 2021

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Nix (116 forks)github user discovery
good first issuerefactoring

Repository metrics

Stars
 (835 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

During work on type shifts, the coerce gets sprinkled over the code.

Eventually, when types line-up - some of the coerce sprinkled over the codebase become superfluous (Path -> Path & such).

There probably shouldn't be many of them, but also finding & removing them would make the code not only cleaner also reducing their number - prevents type inference problems during work.

Contributor guide

Research direction
Search for all uses of `coerce` in the codebase and check if the source and target types are identical, indicating the coerce is superfluous.
Tech stack
haskell
Domain
compilerstooling
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Haskell
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70