hashmapinc/tempus-edge

refactor protobuf usage throughout

Open

#74 opened on Apr 12, 2018

View on GitHub
 (0 comments) (0 reactions) (1 assignee)Scala (1 fork)auto 404
bugenhancementgood first issuein progress

Repository metrics

Stars
 (5 stars)
PR merge metrics
 (PR metrics pending)

Description

Proto objects in scala may currently use a fragile instantiation. make sure each protobuf useage in the scala applications declare an empty proto object and only uses the getters and setters to fill the proto object.

This will avoid hard to debug errors if proto definitions change over time. A change that would result in a bad proto will be more likely to fail at compile time if we use the getters / setters.

Contributor guide

Research direction
Review all protobuf object instantiations in Scala files and refactor to use empty constructor followed by setters for fields.
Tech stack
scala
Domain
backendinfrastructure
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ScalaProtobufGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75