hashmapinc/Tempus

Clean up controller injection

Open

#493 opened on Jun 25, 2018

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Java (11 forks)auto 404
DebtTempus/Applicationcleanupenhancementgood first issue

Repository metrics

Stars
 (31 stars)
PR merge metrics
 (PR metrics pending)

Description

Throughout the UI/src, many controllers have dependency injection for variables that are never used.

Please remove all unused dependency injection from all controllers

Be careful and make sure you don't break anything.

<3

Contributor guide

Research direction
Inspect each controller file in UI/src, look for constructor parameters that are not used in any method, and remove those injections safely.
Tech stack
typescriptangular
Domain
frontend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85