hashicorp/packer

The -NonInteractive Parameter should be added by default when starting a powershell shell

Open

#12,637 opened on Sep 27, 2023

View on GitHub
 (3 comments) (2 reactions) (0 assignees)Go (13,697 stars) (3,228 forks)batch import
enhancementhelp wantedprovisioner/powershell

Description

When a script called by the Powershell provisioner includes a command that involves a y/n prompt (or other kinds of interaction (e.g., Read-Host) the Powershell script will appear to hang as that script will wait indefinitely for the input. The -NonInteractive Parameter should be added by default when using the Powershell provisioner. This would result in an error instead of the apparent hanging when using commands requiring interactivity.

This can currently be worked around by specifying a custom execute_command, but it would be preferable to set the parameter by default.

Originally posted by @floh96 in https://github.com/hashicorp/packer/issues/4916#issuecomment-1239297541

Contributor guide

Tech stack
goshell
Domain
devopsinfrastructure
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Go programmingPacker provisionersPowerShell
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Look at the PowerShell provisioner code in Packer, likely in the 'provisioner/powershell' directory. The issue references a workaround using custom execute command; the fix involves adding ' NonInteractive' to the default command. Check how the default execute command is constructed and where to add the parameter. There is no linked PR or assignee, so this is available for a new contributor.