Do() should checks about CheckRetry value before calling it

Open Beginner friendly
#108 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
65/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Quiet
Tech stack
go
Domain
networking

Research direction

Start at the Do() entry point and trace where CheckRetry is called, using the issue's manually constructed http.Client example to reproduce the nil-value failure. Ensure the retry check handles an unset CheckRetry without a segfault, then verify that normal retryablehttp.NewClient() behavior remains unchanged.

Written by the indexing model from the issue text.

Description

I have integrated go-retryablehttp but went into an issue on segfault when Do() function calls "CheckRetry".

That was because my code create the Client struct itself using:
hc := &http.Client{}

So all extra members of the Client object were not defined (like CheckRetry).

Switching to:
hc := retryablehttp.NewClient()
Fixed the issue.

So, I think the library should check "CheckRetry" value before calling it.

Dominant language
Go
Stars
2.4k
Forks
298
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from hashicorp/go-retryablehttp

All issues in hashicorp/go-retryablehttp

Similar issues

More Go issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.