hashicorp/consul

"consul agent" should support -token-file

Open

#9,723 opened on Feb 5, 2021

View on GitHub
 (4 comments) (6 reactions) (1 assignee)Go (4,588 forks)batch import
good first issuetheme/aclstheme/clitype/enhancement

Repository metrics

Stars
 (29,891 stars)
PR merge metrics
 (Avg merge 8d 12h) (41 merged PRs in 30d)

Description

Please search the existing issues for relevant feature requests, and use the reaction feature (https://blog.github.com/2016-03-10-add-reactions-to-pull-requests-issues-and-comments/) to add upvotes to pre-existing requests.

Feature Description

The consul login command has the ability to write tokens to files, namely the -token-sink-file option. It would be nice if the consul agent command would get a -token-file option (incl. the CONSUL_HTTP_TOKEN_FILE env var) to make those two commands integrate nicely.

Use Case(s)

Generating a token and then using it requires to manually or using 3rd party tools (e.g. jq) to produce valid client config files or hcl fragments.

Contributor guide

Research direction
Implement a token file flag for the `consul agent` command that reads a token from a file, similar to the token sink file flag in `consul login`. Add corresponding CONSUL HTTP TOKEN FILE environment variable. Modify the agent's token loading logic to support this new option.
Tech stack
go
Domain
backendinfrastructuresecurityauthentication
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GoCLI designConsul internals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60