hasadna/open-bus-map-search

Fix lint issues

Open

#450 opened on Jan 31, 2024

View on GitHub
 (8 comments) (0 reactions) (3 assignees)TypeScript (125 forks)auto 404
cifrontendgood first issuehacktoberfestlow priority

Repository metrics

Stars
 (95 stars)
PR merge metrics
 (PR metrics pending)

Description

open eslint.config.js delete lines with rules that are turned 'off'. After deleting each line, run npm run lint, fix all warnings, and commit the changes. It's recommended to make multiple pull requests, in order to break down this task, this task can have multiple assignees.

  • '@typescript-eslint/no-unsafe-call': 'off',
  • '@typescript-eslint/no-unsafe-member-access': 'off',
  • '@typescript-eslint/no-unsafe-return': 'off',
  • '@typescript-eslint/no-floating-promises': 'off',
  • '@typescript-eslint/restrict-template-expressions': 'off',
  • '@typescript-eslint/no-base-to-string': 'off',
  • '@typescript-eslint/no-unsafe-assignment': 'off',
  • '@typescript-eslint/no-unsafe-argument': 'off',

also, deleting eslint-disable comments would be amazing.

Contributor guide

Research direction
Identify lines in eslint.config.js where rules are set to 'off', remove those lines, run npm run lint to find warnings, and fix each warning. Also remove any eslint disable comments in the codebase.
Tech stack
javascripttypescriptnodejs
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitJavaScript/TypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85