hasadna/open-bus-map-search

stride-api: add siri_ride.scheduled_time_gtfs_ride_id to all the siri_ride related APIs

Open

#259 opened on Nov 30, 2023

View on GitHub
 (3 comments) (0 reactions) (2 assignees)TypeScript (125 forks)auto 404
backendgood first issue

Repository metrics

Stars
 (95 stars)
PR merge metrics
 (PR metrics pending)

Description

scheduled_time_gtfs_ride_id is the FQ that matches siri to gtfs (the one which we use to create the gtfs_ride_agg route that is used in the dashboard). When I added it, I forgot to also add it in all the APIs that return siri_rides. We should add it, so we can perform some data researches without using the aggregated route.

Contributor guide

Research direction
Add the field `scheduled time gtfs ride id` to all APIs that return `siri ride` objects. Locate the API response definitions (likely in TypeScript files) and include the new field.
Tech stack
typescript
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70