`BitTiming.from_sample_point` rejects valid timing solutions due to hardcoded register limits
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 72/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Quiet
- Tech stack
- python
- Domain
- embedded-iot
Research direction
Start in bit_timing.py with BitTiming.from_sample_point and follow its call to iterate_from_sample_point, then inspect _restrict_to_minimum_range and _validate. Verify that caller-supplied register limits allow the STM32G431 example to produce brp=40, tseg1=13, and tseg2=2, while the existing default limits preserve current behavior.
Written by the indexing model from the issue text.
Description
Description
BitTiming.from_sample_point cannot find valid bit timings for some clock/bitrate combinations. The method calls iterate_from_sample_point, which constructs each BitTiming with strict=True. This parameter cannot be changed by the caller.
The _validate method enforces hardcoded register limits:
tseg1≤ 16tseg2≤ 8brp≤ 64
The strict mode tightens brp further to 32. These limits follow the CAN 2.0 minimum register specification. Many modern controllers support larger register ranges.
When a clock/bitrate combination produces timing values that all exceed at least one of these limits, the solver rejects every solution and raises ValueError.
Example
STM32G431 with candlelight v2.5 firmware from https://github.com/Elmue/CANable-2.5-firmware-Slcan-and-Candlelight has a 160 MHz CAN clock. The FDCAN peripheral supports brp up to 512 and tseg1 up to 256.
from can import BitTiming
bt = BitTiming.from_sample_point(f_clock=160_000_000, bitrate=250_000, sample_point=87.5)
# Raises: ValueError: No suitable bit timings found.
The valid solution is brp=40, tseg1=13, tseg2=2 (sample point = 87.5% exact). The solver finds this combination but rejects it because brp=40 exceeds the strict limit of 32.
All lower prescaler values produce tseg1 values that exceed 16:
| brp | tseg1 | tseg2 | sample point | rejected by |
|---|---|---|---|---|
| 16 | 34 | 5 | 87.50% | tseg1 > 16 |
| 20 | 27 | 4 | 87.50% | tseg1 > 16 |
| 32 | 17 | 2 | 90.00% | tseg1 > 16 |
| 40 | 13 | 2 | 87.50% | brp > 32 (strict) |
Affected code
bit_timing.py—iterate_from_sample_pointpassesstrict=Truewith no option to overridebit_timing.py—_restrict_to_minimum_rangelimitsbrpto 32bit_timing.py—_validatelimitstseg1to 16,tseg2to 8,brpto 64
Suggested fix
Add optional limit parameters to from_sample_point and iterate_from_sample_point:
@classmethod
def from_sample_point(
cls,
f_clock: int,
bitrate: int,
sample_point: float = 69.0,
tseg1_max: int = 16,
tseg2_max: int = 8,
brp_max: int = 64,
) -> "BitTiming":
Pass these limits through to _validate instead of using hardcoded values. This approach lets callers supply the actual register ranges reported by the hardware. The defaults remain unchanged, so existing behavior is not affected.
The gs_usb interface could populate these limits automatically from the device's GS_USB_BREQ_BT_CONST capability response, which already reports tseg1_max, tseg2_max, and brp_max.
Workaround
Construct the BitTiming object directly. The constructor defaults to strict=False:
bt = BitTiming(f_clock=160_000_000, brp=40, tseg1=13, tseg2=2, sjw=2)
Affected version
4.6.1 (also present on main)
- Dominant language
- Python
- Stars
- 1.6k
- Forks
- 697
- PR merge metrics
- No merged PRs in 30d
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from hardbyte/python-can
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
hardbyte/python-can#2103 ·
-
bug
Difficulty 1/5 Under an hour Newbie friendliness 78/100
hardbyte/python-can#2077 · 1 comment · 1 reaction ·
-
bug
Difficulty 1/5 Under an hour Newbie friendliness 68/100
hardbyte/python-can#1922 · 1 reaction ·
-
enhancement
Difficulty 5/5 Over a week Newbie friendliness 30/100
hardbyte/python-can#2102 ·
-
bug
Difficulty 3/5 1-2 days Newbie friendliness 68/100
hardbyte/python-can#2092 ·
All issues in hardbyte/python-can
Similar issues
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 90/100
learningequality/ricecooker#747 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
BSData/horus-heresy-3rd-edition#3171 ·
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
run-llama/llama_index#23199 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
KhronosGroup/glTF-Blender-IO#2769 ·