Delete worked even when not focused on the canvas

Open Beginner friendly
#12 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
68/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
typescript
Domain
frontend

Research direction

Find the delete/backspace listener currently attached to window and trace how the canvas handles selected nodes. Move the listener's scope to the canvas, then verify that deletion still works when the canvas is focused but does not remove a selected node while typing in an input textbox elsewhere on the page.

Written by the indexing model from the issue text.

Description

bug good first issue

Currently, if we select a node, and then type on some input textbox anywhere on the page, and then we press the delete/backspace button, the selected node got deleted.

The delete button listener shouldn't be attached to the window, but should be attached to the canvas.

Dominant language
TypeScript
Stars
6
Forks
0
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from harchcode/web-digraph

All issues in harchcode/web-digraph

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.