handshake-org/hsd

Improve test coverage

Open

#684 opened on Jan 11, 2022

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (1,814 stars) (286 forks)batch import
Good first issuetests

Description

I noticed in the coverage report that a lot of the wallet make___() errors are not covered (eg "Auction is not yet open" and "Name has not reached bidding phase", etc). This could be another "good first issue" that would be easy to do and get a few more lines covered.

Originally posted by @pinheadmz in https://github.com/handshake-org/hsd/issues/683#issuecomment-1009248506

Contributor guide

Tech stack
javascript
Domain
testing
Issue type
test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Node.jsbasic testing knowledge
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85
Research direction
The issue requests adding test coverage for wallet `make ()` error messages. Review the referenced comment in issue #683 for context. Locate the wallet module in the codebase, identify all error strings (e.g., 'Auction is not yet open'), and write unit tests that verify these errors are thrown correctly under relevant conditions.