handlebars-lang/handlebars.js

Typings allow calling "compile" when including "handlebars/runtime".

Open

#1513 opened on Mar 16, 2019

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (17,697 stars) (2,032 forks)batch import
bughelp wantedtypingsunverified

Description

This issue is actually not verified, but maybe someone can verify and fix it:

The typings of "handlebars/runtime" currently include "handlebars.d.ts", so the "compile"-method is probably part of the typings for "handlebars/runtime". This is nonsense of course. It should only be in "handlebars".

I think the inclusion should be the other way around: Most typings should be in "runtime.d.ts". "handlebars.d.ts" should include them and add "compile" and "precompile".

Contributor guide

Tech stack
typescriptjavascript
Domain
developer experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
TypeScripthandlebars.js type definitions structure
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85
Research direction
Examine the handlebars.d.ts and runtime.d.ts files in the repository. The fix involves moving the shared typings into runtime.d.ts and importing them in handlebars.d.ts, then adding the compile and precompile methods to handlebars.d.ts only. No linked PRs or comments provide further guidance; follow the issue description.