handlebars-lang/handlebars.js

Typings allow calling "compile" when including "handlebars/runtime".

Open

#1,513 opened on Mar 16, 2019

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (2,032 forks)batch import
bughelp wantedtypingsunverified

Repository metrics

Stars
 (17,697 stars)
PR merge metrics
 (Avg merge 15d) (4 merged PRs in 30d)

Description

This issue is actually not verified, but maybe someone can verify and fix it:

The typings of "handlebars/runtime" currently include "handlebars.d.ts", so the "compile"-method is probably part of the typings for "handlebars/runtime". This is nonsense of course. It should only be in "handlebars".

I think the inclusion should be the other way around: Most typings should be in "runtime.d.ts". "handlebars.d.ts" should include them and add "compile" and "precompile".

Contributor guide

Research direction
Inspect handlebars.d.ts and runtime.d.ts in the repository. Move common typings to runtime.d.ts and have handlebars.d.ts extend it. Then add compile and precompile only in handlebars.d.ts.
Tech stack
javascripttypescript
Domain
developer experiencetooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
TypeScriptGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70