hadolint/hadolint

Suggest --fail to curl

Open

#396 opened on Feb 15, 2020

View on GitHub
 (0 comments) (3 reactions) (0 assignees)Haskell (492 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (12,138 stars)
PR merge metrics
 (Avg merge 5d 13h) (8 merged PRs in 30d)

Description

  • This is a bug report
  • This is a feature request
  • I searched existing issues before opening this one

Suggestion

Suggest to add --fail to curl so that the exit code is 0> when something fails.

See https://github.com/docker-library/dockerfile-validator/blob/master/dockerfile-validator#L160

Contributor guide

Research direction
Add the fail flag to the curl command in the script at line 160 of dockerfile validator.
Tech stack
shell
Domain
cli
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitShell
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85