hackmdio/codimd

Feature: Restrict who can log in via Google OAuth via email domain

Open

#973 opened on Sep 28, 2018

View on GitHubContributor guide
 (1 comment) (0 reactions) (0 assignees)JavaScript (1,038 forks)batch import
Hacktoberfestfeature

Repository metrics

Stars
 (8,949 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

As far as I can tell there is currently no way to restrict who can log in via Google OAuth to your CodiMD instance.

I'm thinking of something like the --email-domain= setting from the oauth2_proxy.

Contributor guide

Research direction
Implement a configuration option (e.g., environment variable or config file) that restricts Google OAuth login to specific email domains. Modify the OAuth callback handler to check the user's email domain against the allowed list before creating a session.
Tech stack
javascriptnodejs
Domain
backendauthentication
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitOAuth
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60