guyzmo/git-repo

No way to close a merge request without merging it

Open

#154 opened on May 7, 2017

View on GitHub
 (1 comment) (0 reactions) (1 assignee)Python (837 stars) (86 forks)batch import
backlogenhancementgood first issuehelp wanted

Description

There's an API for that, at least for github:

https://developer.github.com/v3/pulls/#update-a-pull-request

Contributor guide

Tech stack
pythonrest api
Domain
cliapi
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
PythonGitHub API
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
The issue requests a command to close a merge request without merging. The GitHub API endpoint for updating a pull request (PATCH /repos/{owner}/{repo}/pulls/{pull number}) can set the state to 'closed'. Look at existing commands in the repo, e.g., how merge requests are opened or merged. The code is likely in a file like 'git repo/commands/merge request.py'. Check the existing 'close' functionality for issues to replicate the pattern for merge requests.
No way to close a merge request without merging it · guyzmo/git-repo#154 | Good First Issue