guyzmo/git-repo

config wizard does not work if ~/.config/git/config contains include statements

Open

#153 opened on May 7, 2017

View on GitHub
 (5 comments) (0 reactions) (0 assignees)Python (837 stars) (86 forks)batch import
backlogbughelp wanted

Description

Steps to reproduce:

  • Make sure ~/.git does not exist
  • Create ~/.config/git/config` with a least two includes, like so:
[include]
path = /path/to/1
path = /path/to/2

Run git-repo config, do the oauth dance.

Nothing is stored.

PS: I think this is a bug in the code that reads and writes git config. If I were you, I'll just run git config --get foo.bar and git config --global foo.bar 42 instead of using a re-implementation of git config parsing in Python.

Contributor guide

Tech stack
python
Domain
clitooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Pythongit config basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Investigate the config reading/writing module in the repository (likely a Python module). The issue suggests replacing custom parsing with calls to `git config get` and `git config global`. Look for where include directives are not handled correctly. Consider implementing the suggested approach or fixing the parsing to handle multiple includes.