guardian/scribe

Add UMD

Open

#83 opened on Mar 24, 2014

View on GitHub
 (69 comments) (0 reactions) (0 assignees)JavaScript (3,516 stars) (265 forks)batch import
enhancementhelp wanted

Description

This module should work in CommonJS, AMD, and browser globals. Currently it only works for AMD.

Ideally this wrapping would be done as part of the build process.

Re. https://github.com/guardian/scribe/issues/77

Contributor guide

Tech stack
javascript
Domain
build system
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Understanding of UMD module patternFamiliarity with the build process in Plumbing.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
The issue requests adding UMD support to the build process. Start by examining the build script at https://github.com/guardian/scribe/blob/caf781f8bc386058fa9f69bc14c0ded944d12eab/Plumbing.js#L51. Also refer to the linked issue #77 for context. Note that the repository is deprecated, so any work may be for learning purposes only.