guardian/scribe

Code button in the demo not working properly

Open

#482 opened on Jun 9, 2016

View on GitHub
 (2 comments) (0 reactions) (1 assignee)JavaScript (3,516 stars) (265 forks)batch import
bughelp wanted

Description

Hi Guardian team!

Using Chrome 51 on Windows.

When I try your current demo, the Code button is not working correctly. It is like the editor did't recognize that some text was already wrapped in <code>, so it keeps wrapping it over and over instead of removing the code formatting after second click.

How to reproduce:

  1. Open the demo
  2. Select the word World
  3. Press Code button
  4. Press Code button again

Expected: The selected word would be wrapped in <code> and then unwrapped. Actual: The selected word is wrapped twice (<code><code>World</code></code>)

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic JavaScriptunderstanding of rich text editing
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35
Research direction
Examine the code button handler in the Scribe editor source. The issue is that toggling code formatting does not correctly detect existing `<code>` wrappers, causing nested wrapping. Look for the function that toggles code formatting, likely in the `scribe.js` or a plugin file. Check if there are existing tests for the code button to understand the expected behavior. The assigned user may have a fix in progress; check the assignee's branch or linked work.