guardian/scribe

br tags in headings

Open

#481 opened on Jun 7, 2016

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (3,516 stars) (265 forks)batch import
bughelp wanted

Description

It seems like <br> in h1/h2/h3 etc. tags makes document.execCommand('formatBlock', false, 'p') function work not the way it have to.

Way to reproduce bug at the demo-page:

  1. create three <p>-paragraphs
  2. select them
  3. click h2-button, so you get <h2>Hello, World!<br>Hello, World!<br>Hello, World!</h2>
  4. set caret after last <br> and try to click h2-button again to remove h2 tag. It will not work.
  5. If you wil set caret before <br> and try to click h2, at first it will remove <br>-tag and after another click it will acts like it have to.

Contributor guide

Tech stack
javascripthtml
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Understanding of execCommandKnowledge of HTML DOM manipulation
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Investigate the scribe source code, particularly the implementation of formatBlock for headings. Check how the editor handles <br> elements inside headings during formatting toggling. Look at the specific commands that process selection and block formatting. The issue likely lies in the logic that removes heading tags when <br> is present. See files related to command execution and HTML normalization.