guardian/scribe

br tags in headings

Open

#481 opened on Jun 7, 2016

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (265 forks)batch import
bughelp wanted

Repository metrics

Stars
 (3,516 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

It seems like <br> in h1/h2/h3 etc. tags makes document.execCommand('formatBlock', false, 'p') function work not the way it have to.

Way to reproduce bug at the demo-page:

  1. create three <p>-paragraphs
  2. select them
  3. click h2-button, so you get <h2>Hello, World!<br>Hello, World!<br>Hello, World!</h2>
  4. set caret after last <br> and try to click h2-button again to remove h2 tag. It will not work.
  5. If you wil set caret before <br> and try to click h2, at first it will remove <br>-tag and after another click it will acts like it have to.

Contributor guide

Research direction
Examine the formatBlock implementation in the codebase, focusing on how <br> elements inside headings are handled. Trace the logic when formatBlock is called with 'p' to remove the heading. Check if the presence of <br> causes the selection to be incorrectly resolved.
Tech stack
javascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75