guardian/scribe

node.children is undefined?

Open

#462 opened on Mar 15, 2016

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (265 forks)batch import
beginnerhelp wanted

Repository metrics

Stars
 (3,516 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

In this function, did you really mean node or element?

Because Node objects do not have the children property - only Element objects have that.

Contributor guide

Research direction
Inspect the code at src/node.js line 19 to determine whether `node` refers to an `Element` or a general `Node`. If it is an `Element`, the `children` property is valid. Otherwise, consider using `childNodes` or adjusting the type.
Tech stack
javascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75