guardian/scribe

node.children is undefined?

Open

#462 opened on Mar 15, 2016

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (3,516 stars) (265 forks)batch import
beginnerhelp wanted

Description

In this function, did you really mean node or element?

Because Node objects do not have the children property - only Element objects have that.

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90
Research direction
The issue points to a specific line in src/node.js (line 19) where `node.children` is used. Confirm that the variable is an Element or change to `node.childNodes` if it should work with Node. The repository is deprecated (last commit years ago), so the fix may not be merged but is a good learning exercise.