guardian/scribe

Linking doesn't work correctly when keyboard used to select text in firefox

Open

#437 opened on Oct 20, 2015

View on GitHub
 (3 comments) (0 reactions) (1 assignee)JavaScript (3,516 stars) (265 forks)batch import
browser inconsistencyhelp wanted

Description

If you select text using the keyboard in firefox (e.g. shift+left) then add a link (either with the button or cmd+k) then the link itself gets pasted in instead of the text being linked. This doesn't happen in chrome.

Contributor guide

Tech stack
javascripthtmlcss
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
understanding of browser eventsJavaScript basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
The issue describes a bug in Firefox where using keyboard to select text and then adding a link incorrectly replaces the selection with the link URL instead of wrapping the selected text. Investigate the editor's link insertion logic, likely in the command or formatting module. Compare behavior with Chrome to identify Firefox specific event handling differences. Check existing comments for any identified root causes.