guardian/scribe

Indent action is inconsistent when paragraph is split with BR tags

Open

#381 opened on Apr 10, 2015

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (3,516 stars) (265 forks)batch import
bughelp wanted

Description

Using the live demo at http://guardian.github.io/scribe/ in Chrome 41 on Windows 8:

Step 1. Type test three times:

test
test
test

Which results in this HTML:

<p>test</p><p>test</p><p>test</p>

Step 2. Select all the text, then press H2 twice, which results in this HTML:

    <p>test<br>test<br>test</p>

Step 3. Press indent, results in this HTML:

    <blockquote><p>test</p><p>test</p><p>test</p></blockquote>

However, the selection now only extends to the "te" in the final "test", the "st" is unselected. Presumably due to the conversion from br to p tags.

Step 4. Press Outdent, results in this HTML:

    <p>test</p><p>test</p><p>te</p><blockquote><p><br></p><p>st</p></blockquote>

The "st" which ended up becoming deselected is still indented. Expected result is the html after step 1, with just three paragraph tags. The html at step 2 should probably match the html after step 1 too.

Contributor guide

Tech stack
javascripthtmlcss
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScriptDOM manipulationHTML
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
The issue describes inconsistent indentation when handling multiple paragraphs separated by BR tags. Investigate the indent and outdent functions in the source code (likely in scribe plugin indent or similar). Focus on how the selection is preserved when converting between <br> and <p> elements. Look at the code for indent/outdent commands and how they interact with the scribe selection API. Check for any existing tests related to this behavior.