guardian/scribe

Undo manager prevents entering Alt + Z special characters

Open

#282 opened on Oct 30, 2014

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (3,516 stars) (265 forks)batch import
enhancementhelp wanted

Description

Hey guys,

we were just reported that some of our users can't enter special chars like ż, Ż (alt + z). That event.metaKey in undo / redo commands messes it up. Can't think of any good way to fix this, so I'm not creating a pull request.

In our case - we just stopped using undo / redo by removing the key bindings, but it would be great to be able to use those while not loosing those special Z chars.

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
JavaScript event handlingUndo/redo manager concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
Examine the undo manager's key binding implementation, likely in a file like `undo manager.js` or similar. Look for the handler that listens for Ctrl+Z / Cmd+Z. Modify the condition to exclude cases where Alt key is pressed (event.altKey). Ensure Alt+Z can be typed normally. Test multiple browsers and report findings.