guardian/scribe

Make sure scribe markers are not left around

Open

#278 opened on Oct 24, 2014

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (3,516 stars) (265 forks)batch import
beginnerhelp wanted

Description

Scribe markers are currently left all over the place. Look at this https://github.com/guardian/scribe/pull/248 for an example.

The approach here from @chanon is simple but should be merged as part of a separate pull request as checking the range was done in https://github.com/guardian/scribe/pull/273

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
needs investigation
Prerequisites
basic understanding of Scribefamiliarity with DOM range
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
First, review the linked PR #248 to understand the approach suggested by chanon. Then, examine the current state of scribe markers in the source code, particularly in the relevant module (likely the selection or range handling). Check PR #273 for the range checking work that was done. The fix likely involves ensuring that when a selection or range is applied, any temporary markers are cleaned up. Since the repo is deprecated, consider if the issue is still relevant.