guardian/scribe

`underline` command is "enabled" when cursor is inside an <a> link

Open

#206 opened on Jun 20, 2014

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (3,516 stars) (265 forks)batch import
browser inconsistencybughelp wantedpatch needed

Description

It seems like the default "underline" command checks the enabled CSS of the current selection, rather than looking for an explicit <u> element.

We were able to fix this locally easily by overriding the default "underline" queryState() command to look for an explicit <u> tag instead of relying on the default behavior.

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic JavaScriptunderstanding of DOM events
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Examine the default underline command's `queryState()` method in Scribe's source code (likely in `underline.js` or similar). The issue indicates it checks CSS `enabled` instead of looking for an explicit `<u>` element. The fix involves overriding that method to detect `<u>` tags. Review the existing override pattern in the codebase to ensure consistency.