guardian/scribe

Chrome: Pasting from Word into pristine editor creates extraneous P element and misplaces the caret

Open

#137 opened on Apr 30, 2014

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (265 forks)batch import
browser inconsistencyformattershelp wanted

Repository metrics

Stars
 (3,516 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

image

Pasted into a pristine editor:

image

  • The caret is before the "3" when it should be after.
  • There is an extraneous P element containing only whitespace after the paragraph containing "2".

To do: create isolated case.

Introduced by https://github.com/guardian/scribe/pull/131.

Contributor guide

Research direction
Inspect the pasting logic in Scribe's handler, especially the handling of Word clipboard data and the insertion of paragraphs. Look at the PR #131 which introduced the issue to understand the change, then isolate the case in a pristine editor.
Tech stack
javascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70