grpc/grpc-java

Support SslMasterKeyHandler in NettyServerBuilder

Open

#7,199 opened on Jul 10, 2020

View on GitHub
 (15 comments) (1 reaction) (0 assignees)Java (3,742 forks)batch import
enhancementgood first issue

Repository metrics

Stars
 (11,124 stars)
PR merge metrics
 (Avg merge 23d 22h) (43 merged PRs in 30d)

Description

I have a problem with adding SslMasterKeyHandler#newWireSharkSslMasterKeyHandler on the server side. I tried to do this with channelFactory:

builder.channelFactory(() -> {
          final ServerChannel ch = GrpcUtil.getDefaultServerChannelFactory().newChannel();
          final ChannelPipeline pipeline = ch.pipeline();
          pipeline.addLast(SslMasterKeyHandler.newWireSharkSslMasterKeyHandler());
          return ch;
        })

and later with ProtocolNegotiator:

final SslContext sslContext = GrpcSslContexts.configure(sslClientContextBuilder).build();
final io.grpc.netty.ProtocolNegotiator negotiator = ProtocolNegotiators.serverTls(sslContext);
builder.protocolNegotiator(tlsNegotiator(negotiator);

In the first case, the setting had no effect. In the second case, the server worked incorrectly (it stopped accepting connections, even without a handler, just with a negotiator wrapper).

What should be the proper implementation?

Contributor guide

Research direction
Investigate how to add SslMasterKeyHandler to the Netty pipeline in gRPC Java server. Consider using serverBuilder.addChannelFactory or modifying the ProtocolNegotiator. Look at existing examples or code for SSL/TLS setup in gRPC.
Tech stack
java
Domain
backendsecurity
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavagRPC Java
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60