grpc/grpc-java

Verify server sends grpc-accept-encoding appropriately

Open

#1,804 opened on May 6, 2016

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Java (3,742 forks)batch import
help wanted

Repository metrics

Stars
 (11,124 stars)
PR merge metrics
 (Avg merge 23d 22h) (43 merged PRs in 30d)

Description

If the client sends a gzip-encoded request and the server responds with headers (endStream=false) that does not include grpc-accept-encoding gzip, then the client should warn. This is misbehavior on the server-side and would ideally be detected.

Although I said "warn" above, we're actually aware of servers failing to do this properly today. So initially we can use FINE and eventually swap it to warn.

Contributor guide

Research direction
Investigate how the server currently sets grpc accept encoding header in response headers and locate where to add a warning if gzip is missing.
Tech stack
javagrpc
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavagRPC
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70