grpc/grpc-java

Support --incompatible_enable_proto_toolchain_resolution

Open

#11,152 opened on May 6, 2024

View on GitHub
 (8 comments) (4 reactions) (0 assignees)Java (11,124 stars) (3,742 forks)batch import
Waiting on reporterenhancementhelp wanted

Description

Is your feature request related to a problem?

The problem is need to compile protoc instead of using prebuilt binary while building java_grpc_library

Describe the solution you'd like

Support --incompatible_enable_proto_toolchain_resolution bazel flag so users can override protoc compiled from sources with prebuilt binary, as already done in rules_python or WIP in rules_go

Describe alternatives you've considered

Additional context

Examples of declarations toolchains for other languages that already support the feature here

Contributor guide

Tech stack
java
Domain
build systembackend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
BazelJavagRPCProtobuf toolchains
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
Study the referenced PRs in rules python and rules go to understand the pattern for supporting incompatible enable proto toolchain resolution. Examine the example toolchain declarations in aspect build/toolchains protoc. Then implement similar toolchain registration in grpc java's Bazel build files, likely in the grpc java repository's BUILD files or proto rules. Coordinate with maintainers to ensure compatibility.