grpc/grpc-java

Support --incompatible_enable_proto_toolchain_resolution

Open

#11,152 opened on May 6, 2024

View on GitHub
 (8 comments) (4 reactions) (0 assignees)Java (3,742 forks)batch import
Waiting on reporterenhancementhelp wanted

Repository metrics

Stars
 (11,124 stars)
PR merge metrics
 (Avg merge 23d 22h) (43 merged PRs in 30d)

Description

Is your feature request related to a problem?

The problem is need to compile protoc instead of using prebuilt binary while building java_grpc_library

Describe the solution you'd like

Support --incompatible_enable_proto_toolchain_resolution bazel flag so users can override protoc compiled from sources with prebuilt binary, as already done in rules_python or WIP in rules_go

Describe alternatives you've considered

Additional context

Examples of declarations toolchains for other languages that already support the feature here

Contributor guide

Research direction
Explore how to add Bazel toolchain support for protoc in grpc java by following the examples from rules python and rules go. The goal is to use the incompatible enable proto toolchain resolution flag to allow users to use a prebuilt protoc binary instead of compiling it from source.
Tech stack
java
Domain
backendbuild system
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
BazelProtobuf
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40