grpc-ecosystem/grpc-gateway

Possible regression when specifying duplicate paths

Open

#830 opened on Dec 12, 2018

View on GitHub
 (7 comments) (0 reactions) (0 assignees)Go (16,971 stars) (2,250 forks)batch import
bughelp wanted

Description

I haven't got a lot of time to debug this right now, but at work I've recently run into several instances of the generator not erroring when specifying duplicate paths, like so:

get: "/api/v1/users/{user_id}"
...
get: "/api/v1/users/things"

The second one should not be allowed because it is ambiguous with the first one. I'm pretty sure this used to work, so I assume it's a regression. I'm raising just so I don't forget about it. This is happening on latest master.

Contributor guide

Tech stack
gogrpcrest api
Domain
backendapitooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Go programminggRPC basicsgrpc gateway codebase structure
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
The issue is a regression: duplicate paths should trigger an error but do not. Examine the generator's route validation logic, likely in the `internal/descriptor` or `protoc gen grpc gateway` packages. Look for recent commits that might have removed the duplicate path check. Check the test files for any existing tests for duplicate paths. The maintainers may need to confirm the expected behavior.