grpc-ecosystem/grpc-gateway

Add Bytes and Enum handlers to `proto2ConvertFuncs`

Open

#779 opened on Oct 15, 2018

View on GitHub
 (12 comments) (0 reactions) (0 assignees)Go (16,971 stars) (2,250 forks)batch import
enhancementhelp wanted

Description

Due to backward compatibility issue, I am forced to use proto2. I am not sure if my clients can keep on using proto2 and I can move to proto3. Also it is recommended to keep using proto2 as proto3 doesn't have many new features.

So, if I am supposed to use proto2 only, is there a workaround for it given bytes_type and enums are not supported?

Contributor guide

Tech stack
gogrpcrest api
Domain
backendapi
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Go programmingProtocol Buffers (proto2)gRPC Gateway codebase
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Identify the `proto2ConvertFuncs` structure in the source code, likely in `protoc gen grpc gateway/internal/gengateway/template.go`. Review existing handler implementations for proto3 to understand the pattern. Add conversion functions for bytes and enum types for proto2, ensuring they match the expected output format. Check the issue comments for any suggested workarounds that might inform the implementation.