grpc-ecosystem/grpc-gateway

registry: descriptor.Field.FieldMessage is never set

Open

#1136 opened on Feb 17, 2020

View on GitHub
 (5 comments) (0 reactions) (0 assignees)Go (16,971 stars) (2,250 forks)batch import
bughelp wanted

Description

Hi! While fixing a bug in github.com/utrack/clay I've noticed that bindings' Body.FieldPath[].Target.FieldMessage is always nil.

I don't see any references to FieldMessage in grpc-gateway@v1.12.1, so I don't believe there are any bugs related to it, so it can be dropped.

However, the field itself looks useful and is worth to be populated IMO. I'll make a PR if you decide to keep it in the registry.

Contributor guide

Tech stack
gogrpc
Domain
backendapi
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
GogRPCprotobufgrpc gateway
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35
Research direction
Start by examining the descriptor package in protoc gen grpc gateway, focusing on types.go line 219 where FieldMessage is defined. Verify that the field is indeed never set in the codebase (v1.12.1 and later). Check if there are any usages or if it was intended for future use. Since the issue suggests removal or population, evaluate which approach is appropriate. Review the comments on the issue for any additional context. No linked PRs exist.