grpc-ecosystem/grpc-gateway

openapiv2.proto NULL conflict with c++ keyword

Open

#1031 opened on Sep 4, 2019

View on GitHub
 (4 comments) (0 reactions) (0 assignees)Go (16,971 stars) (2,250 forks)batch import
bughelp wanted

Description

https://github.com/grpc-ecosystem/grpc-gateway/blob/3ad0fb96ecfdf73fa2eddb3de116ae98360dbb35/protoc-gen-swagger/options/openapiv2.proto#L218

compiled openapiv2.proto cpp file contains NULL, conflict with c++ keyword. Any suggestion on how to solve this?

Contributor guide

Tech stack
cppgo
Domain
backenddeveloper experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
basic protobuf knowledgeC++ keyword awareness
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
The issue is in the protoc gen swagger/options/openapiv2.proto file at line 218, where the field name 'NULL' conflicts with the C++ keyword 'NULL'. A simple fix would be to rename the field to something like 'null value' or 'null field'. Check the generated C++ code to ensure no other parts depend on the exact field name, and update any corresponding documentation or comments. The issue is open and has had no recent activity; a pull request would be welcome.