groue/GRMustache.swift

Boxed NSObjects fail for Cocoapods installation

Open

#28 opened on Apr 5, 2016

View on GitHub
 (7 comments) (1 reaction) (0 assignees)Swift (154 forks)github user discovery
bughelp wanted

Repository metrics

Stars
 (629 stars)
PR merge metrics
 (PR metrics pending)

Description

When installing the framework via Cocoapods, NSObject subclasses aren't properly boxed, due to the compiler conditional in Box.swift.

Here's a temporary workaround hook for a project's Podfile:

post_install do |installer|
    installer.pods_project.targets.each do |target|
        if target.name == "GRMustache.swift"
            target.build_configurations.each do |config|
                config.build_settings['OTHER_SWIFT_FLAGS'] ||= ['$(inherited)', '-DOBJC']
            end
        end
    end
end

Contributor guide

Research direction
Investigate the compiler conditional in Box.swift around line 527-541 and fix it to support CocoaPods without requiring the DOBJC flag. Test with a sample Podfile.
Tech stack
swift
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
SwiftCocoaPods
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70