gristlabs/grist-core

make limit on API request body size configurable

Open

#916 opened on Mar 27, 2024

View on GitHub
 (2 comments) (0 reactions) (0 assignees)TypeScript (3,613 stars) (168 forks)batch import
good first issue

Description

There is a limit set on the maximum API request body size. That limit is currently hardcoded to 1mb (https://github.com/gristlabs/grist-help/pull/320#issuecomment-2021537352). It would be good to make this configurable, in the same way that related parameters like GRIST_MAX_UPLOAD_IMPORT_MB and GRIST_MAX_UPLOAD_ATTACHMENT_MB are.

Contributor guide

Tech stack
typescriptnodejs
Domain
backend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
familiarity with TypeScriptbasic knowledge of Grist's configuration
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Look at the hardcoded limit referenced in the issue (https://github.com/gristlabs/grist help/pull/320#issuecomment 2021537352). Examine how similar parameters like GRIST MAX UPLOAD IMPORT MB and GRIST MAX UPLOAD ATTACHMENT MB are implemented and made configurable. The goal is to introduce a new environment variable (e.g., GRIST MAX REQUEST BODY MB) and replace the hardcoded value with a check that reads this variable, falling back to 1MB if not set.