graphql/graphql-js

Expand test suite for resolve data

Open

#351 opened on Apr 9, 2016

View on GitHub
 (0 comments) (2 reactions) (0 assignees)TypeScript (19,825 stars) (2,223 forks)batch import
help wanted

Description

Currently there is only one test case for "gets execution info in resolver" which does not test the breadth of execution info. It would be useful to expand the test cases around what information the resolve functions can expect to receive. Currently, only rootValue is tested from the GraphQLResolveInfo parameter. The suite should have the same kind of test for the other fields, especially fieldASTs, returnType, and parentType in nested and nonNull conditions. It should also test all three functions that receive GraphQLResolveInfo.

This can help make it easier to change the execute and resolve process without worrying about regressions.

https://github.com/graphql/graphql-js/blob/master/src/execution/__tests__/union-interface-test.js#L351

Extracting this from #304 as a separate issue.

Contributor guide

Tech stack
javascript
Domain
testing
Issue type
test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Familiarity with GraphQL executionBasic unit testing in JavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75
Research direction
Expand the test cases in src/execution/ tests /union interface test.js (line 351) to cover additional fields of GraphQLResolveInfo: fieldASTs, returnType, and parentType, under nested and nonNull conditions. Also ensure all three resolver functions that receive GraphQLResolveInfo are tested with these parameters. Follow the pattern of the existing test 'gets execution info in resolver' which only tests rootValue; add similar assertions for the other fields.