graphql/graphql-js

merge ast trees

Open

#1,428 opened on Jul 21, 2018

View on GitHub
 (9 comments) (4 reactions) (0 assignees)TypeScript (2,223 forks)batch import
help wantedproposal

Repository metrics

Stars
 (19,825 stars)
PR merge metrics
 (Avg merge 12d 6h) (42 merged PRs in 30d)

Description

Feature request

Another feature that is extremely useful and utils are lacking it: merging ast trees.

Primary use case: merging two queries (selections) to dynamically construct queries. There are plenty of cases where it is needed, mainly in libraries and in cases of graphql to graphql communication.

PS It would be great if somebody can say how to do this properly now (simple deep merge doesn't wotk properly)

Contributor guide

Research direction
Study the GraphQL AST structure in graphql js (e.g., using the `ast` module) and implement a deep merge function that combines two AST trees according to GraphQL's selection set semantics. Ensure handling of conflicts and edge cases.
Tech stack
typescript
Domain
backendapi
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GraphQLTypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60