graphql/graphql-js
View on GitHubIs it possible to make findBreakingChange return line numbers?
Open
#1341 opened on May 8, 2018
7 comments (7 comments)1 reaction (1 reaction)0 assignees (0 assignees)TypeScript19,825 stars (19,825 stars)2,223 forks (2,223 forks)batch import
enhancementhelp wanted
Description
This would help to create some tools, like github pull request checks.
Contributor guide
- Tech stack
- typescript
- Domain
- backendapi
- Issue type
- feature
- DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
- 4
- Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
- over 1 week
- Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
- stale
- ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
- needs investigation
- Prerequisites
- Knowledge of GraphQL schemaUnderstanding of graphql js source codeFamiliarity with AST and location tracking
- Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
- 20
- Research direction
- Examine the current implementation of findBreakingChanges in graphql js, likely in src/utilities/findBreakingChanges.ts. Understand how breaking changes are detected. To return line numbers, you would need to modify the function to include location information from the GraphQL AST (e.g., using the 'loc' property on nodes). Investigate how other parts of the codebase handle location tracking and consider extending the return type to include line and column numbers. Look at existing tests for findBreakingChanges to ensure compatibility.