graphql/graphiql

Field coloring varies based on newlines

Open

#2,354 opened on May 6, 2019

View on GitHub
 (8 comments) (3 reactions) (0 assignees)TypeScript (1,785 forks)batch import
buggood first issuegrammarvscode-graphqlvscode-graphql-syntax

Repository metrics

Stars
 (15,473 stars)
PR merge metrics
 (Avg merge 3d 23h) (50 merged PRs in 30d)

Description

Actual Behavior

Field coloring varies depending whether the opening brace or directive is on the same line as the type definition. Especially in more complex cases (the Bar example below) it may be preferable to have directives on their own lines.

See field: String below:

Expected Behavior

Colors don't change based on locations.

Steps to Reproduce the Problem Or Description

Example code from screenshot:

type Foo1 {
  field: String
}

type Foo2
{
  field: String
}

type Bar1 @auth(rules: [
  { allow: groups, groups: ["Admin"] }
  { allow: groups, groups: ["Everyone"], operations: [read] }
]) {
  field: String
}

type Bar2
@auth(rules: [
  { allow: groups, groups: ["Admin"] }
  { allow: groups, groups: ["Everyone"], operations: [read] }
]) {
  field: String
}

Specifications

  • GraphQL for VSCode Extension Version: 0.1.7
  • VSCode Version: 1.32.3
  • OS Name: macOS
  • OS Version: Mojave

Contributor guide