graphql/dataloader

Ever considered the use of `queueMicrotask`?

Open

#348 opened on Aug 17, 2023

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (12,520 stars) (556 forks)batch import
help wanted

Description

It's available as of v11—isn't it better than process.nextTick? https://nodejs.org/api/globals.html#queuemicrotaskcallback

https://github.com/graphql/dataloader/blob/d336bd15282664e0be4b4a657cb796f09bafbc6b/src/index.js#L239-L255

Just a question...

Thanks, A.

Contributor guide

Tech stack
javascriptnodejs
Domain
performance
Issue type
research
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
needs maintainer response
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Node.jsJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Investigate the differences between queueMicrotask and process.nextTick in Node.js. Review the DataLoader source code at src/index.js lines 239-255 to understand the current usage of process.nextTick. Check the Node.js documentation for queueMicrotask and determine if it is a suitable replacement. Consider any compatibility issues with older Node.js versions. Look at the issue comments for any maintainer feedback. If deemed appropriate, prepare a pull request replacing process.nextTick with queueMicrotask.