How to address inheritance chain changes between Graphene 2 and 3?

Open
#1,592 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
25/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Stale
Tech stack
python

Research direction

The issue names ObjectTypeWithID, ObjectTypeMeta, InterObjectType, and the differing Python MROs, but no repository files or tests. Start by reproducing the inheritance example on Graphene 2.x and 3.x, then inspect the generated MRO and constructor behavior. Done means the intended inheritance behavior is established and the issue has a documented or tested resolution.

Written by the indexing model from the issue text.

Description

🐛 bug
  • What is the current behavior?

In order for us to have consistent IDs and unique IDs for all our entities we made all entities were inheriting from this class:

class ObjectTypeWithID(ObjectType):
    id = ID(required=True, description="globally unique identifier")
    entity_id = String(required=True, description="identifier for the entity")
    model_id = String(required=True, description="identifier for the entity model")

    def __init__(self, id):
        print('!!!ObjectTypeWithID.__init__')
        self.id = generate_global_id(self.__class__.__name__, id)
        self.entity_id = id
        self.model_id = id

# usage 
class User(ObjectTypeWithID)
       def __init__:
             super().__init__(user_id)

This worked fine in Graphene 2.x but once we tried to upgrade to Graphene 3.x it seems like super().__init__ does not trigger ObjectTypeWithID

I checked the mro and I noticed there's now InterObjectType between User and it's parent ObjectTypeWithID and I suspect it's getting in the way when call super()

user.__class__.__mro__ in Graphene 3.x

(
    <User meta=<ObjectTypeOptions name='User'>>, 
    <class 'graphene.types.objecttype.ObjectTypeMeta.new.<locals>.InterObjectType'>, 
    <ObjectTypeWithID meta=<ObjectTypeOptions name='ObjectTypeWithID'>>, 
    <class 'graphene.types.objecttype.ObjectTypeMeta.new.<locals>.InterObjectType'>, 
    <ObjectType meta=None>, 
    <class 'graphene.types.objecttype.ObjectTypeMeta.new.<locals>.InterObjectType'>, 
    <BaseType meta=None>, 
    <SubclassWithMeta meta=None>, <class 'object'>
)

user.__class__.__mro__ in Graphene 2.x

(
        <Campaign meta=<ObjectTypeOptions name='Campaign'>>, 
        <ObjectTypeWithID meta=<ObjectTypeOptions name='ObjectTypeWithID'>>, 
        <ObjectType meta=None>, 
        <BaseType meta=None>, 
        <SubclassWithMeta meta=None>, 
        <class 'object'>
)
Dominant language
Python
Stars
8.2k
Forks
818
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from graphql-python/graphene

All issues in graphql-python/graphene

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.