grafeas/kritis

Rename /integration to /e2etests

Open

#467 opened on Feb 12, 2020

View on GitHubContributor guide
 (1 comment) (0 reactions) (0 assignees)Go (135 forks)auto 404
good first issueintegration-testtechdebttesting

Repository metrics

Stars
 (710 stars)
PR merge metrics
 (PR metrics pending)

Description

Is your feature request related to a problem? Please describe. Currently, integration tests in Kritis means two things:

  1. The integration tests that live inside each individual package. For example, for the containeranalysis package, the integration tests are here.
  2. Tests under /integration folder. These tests are run on a GKE cluster to test the end-to-end functionality of Kritis.

When we talk about integration tests, it is easy to confuse the two.

Describe the solution you'd like

I propose to rename the tests in /integration folder as end to end tests, or e2e tests, and rename the folder as so. We probably also want to change the build tag in /integration/run_tests.go to e2e as well.

Describe alternatives you've considered Do nothing.

Additional context Add any other context or screenshots about the feature request here.

Contributor guide

Research direction
Locate the /integration folder in the repository, rename it to /e2etests, update the build tag in /integration/run tests.go to e2e, and update any references to the old path.
Tech stack
go
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90