grafeas/kritis

Make integration testing project configurable

Open

#466 opened on Feb 12, 2020

View on GitHubContributor guide
 (1 comment) (0 reactions) (0 assignees)Go (135 forks)auto 404
good first issueintegration-test

Repository metrics

Stars
 (710 stars)
PR merge metrics
 (PR metrics pending)

Description

Is your feature request related to a problem? Please describe. Our integration tests has a dedicated GCP project ("kritis-int-test") harded in the tests. For example, for the containeranalysis package here. This makes it hard for a contributor to run those tests if they do not have access to that project. We should make this project configurable so that the tests can be run against a contributor's own GCP project.

Describe the solution you'd like Make the GCP project in integration tests configurable, and provide instructions on how to set them up.

Describe alternatives you've considered Leave as it is.

Additional context

This is specific to integration tests that live in each individual package. The tests under /integration folder is already project-configurable.

Contributor guide

Research direction
Find all hardcoded GCP project references in integration tests and replace them with an environment variable or configuration file. Update documentation to explain how contributors can set up their own GCP project for testing.
Tech stack
gogcp
Domain
backendtesting qa
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GoGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70