grafana/pyroscope

Make all inputs have white background when they are editable

Open

#1642 opened on Oct 26, 2022

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C (9,041 stars) (528 forks)batch import
frontendgood first issue

Description

One needs to go over every single input and make sure it has a white background if it's editable. Example: image

Here's an example of annotations, that does it correctly: timestamp field has a dark background because it's read only. image

Ideally the solution would work out of the box for all inputs.

Contributor guide

Tech stack
None
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85
Research direction
The fix requires identifying all input elements in the frontend and applying a global CSS rule such as `input:not([readonly]) { background color: white; }`. Look for existing CSS files in the repository, possibly in a `styles` or `components` directory. Ensure that readonly inputs retain their current background color.