grafana/mimir

Add warmup to EwmaRate

Open

#5,443 opened on Jul 6, 2023

View on GitHub
 (10 comments) (0 reactions) (0 assignees)Go (808 forks)auto 404
buggood first issue

Repository metrics

Stars
 (5,181 stars)
PR merge metrics
 (PR metrics pending)

Description

Describe the bug

The current math.EwmaRate implementation does not require a warmup period, allowing a rate to be available after a single sample is added, which can lead to unexpected results, as described in #5394. Let's move warmup support from that PR into EwmaRate itself, to avoid problems with other users of this type.

Contributor guide

Research direction
Study the current EwmaRate implementation and the warmup logic from PR #5394. Then implement warmup in EwmaRate by adding a warmup duration parameter, ensuring the rate is not valid until the warmup period has elapsed.
Tech stack
go
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
Go
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50