grafana/loki

Replace `go.uber.go/atomic` with Go standard library `sync/atomic`

Open

#20673 opened on Feb 4, 2026

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Go (28,187 stars) (3,997 forks)batch import
good first issue

Description

Summary

We currently have a linter rule that blocks usage of sync/atomic and forces us to use go.uber.go/atomic instead. This rule was originally added because sync/atomic required atomic operations on primitive types, which was considered error-prone.

However, since Go 1.19, the standard library sync/atomic package now includes typed wrappers (e.g., atomic.Uint32, atomic.Int64, atomic.Bool, etc.) that provide the same safety guarantees as go.uber.go/atomic. This makes the uber package redundant.

Context

Prometheus is also making this transition:

Proposed Changes

  1. Remove the linter rule that blocks sync/atomic
  2. Migrate all go.uber.go/atomic usage to the standard library sync/atomic typed wrappers
  3. Configure a linter rule to block the old-style atomic functions that operate on primitive types (e.g., atomic.AddInt64, atomic.LoadUint32) to ensure we only use the new typed wrappers and avoid accidental misuse

This approach gives us:

  • Fewer external dependencies
  • Alignment with the broader Go ecosystem
  • Same safety guarantees we had with uber/atomic

References

Contributor guide

Tech stack
go
Domain
backenddeveloper experience
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Go 1.19+ knowledgeUnderstanding of atomic operationsFamiliarity with linter configurationBasic Git workflow
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Start by examining the Go linter configuration file (likely `.golangci.yml` or similar) to remove the rule blocking `sync/atomic`. Then search the entire codebase for imports of `go.uber.org/atomic` and replace them with the equivalent `sync/atomic` typed wrappers (e.g., `atomic.Uint32`, `atomic.Int64`). Refer to the linked Prometheus PR (https://github.com/prometheus/prometheus/pull/18009) for an example of the transition. Ensure that the changes compile and pass tests.